datafactory-track2#20355
Merged
qiaozha merged 6 commits intoAzure:mainfrom Feb 24, 2022
Merged
Conversation
colawwj
requested review from
MaryGao,
deyaaeldeen,
dw511214992,
mikeharder,
praveenkuttappan,
qiaozha and
witemple-msft
as code owners
ghost
added
the
qiaozha
reviewed
Feb 21, 2022
| "devDependencies": { | ||
| "@microsoft/api-extractor": "^7.18.11", | ||
| "@rollup/plugin-commonjs": "^21.0.1", | ||
| "@rollup/plugin-commonjs": "11.0.2", |
Member
There was a problem hiding this comment.
why do we have this change ? is it from code generator ?
Contributor
Author
There was a problem hiding this comment.
I have regenerated the package.
qiaozha
reviewed
Feb 21, 2022
| } | ||
| "include": [ | ||
| "./src/**/*.ts", | ||
| "./test/**/*.ts" |
Member
There was a problem hiding this comment.
it should have a "./sample-dev/**/*.ts" if you are using the latest release tool @azure-tools/js-sdk-release-tools
Contributor
Author
There was a problem hiding this comment.
It‘s can not generate code if add parameter of --additional-args="--generate-sample=true
qiaozha
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release for issue:https://github.com/Azure/sdk-release-request/issues/2418